소스 검색

optimize SOCK_CLOEXEC fallback for socket function

the fcntl function is heavy, so make the syscall directly instead.
also, avoid the code size and runtime overhead of querying the old
flags, since it's reasonable to assume nothing will be set on a
newly-created socket. this code is only used on old kernels which lack
proper atomic close-on-exec support, so future changes that might
invalidate such an assumption do not need to be considered.
Rich Felker 11 년 전
부모
커밋
1cacc01dc0
1개의 변경된 파일2개의 추가작업 그리고 2개의 파일을 삭제
  1. 2 2
      src/network/socket.c

+ 2 - 2
src/network/socket.c

@@ -13,9 +13,9 @@ int socket(int domain, int type, int protocol)
 			protocol, 0, 0, 0);
 		if (s < 0) return s;
 		if (type & SOCK_CLOEXEC)
-			fcntl(s, F_SETFD, FD_CLOEXEC);
+			__syscall(SYS_fcntl, s, F_SETFD, FD_CLOEXEC);
 		if (type & SOCK_NONBLOCK)
-			fcntl(s, F_SETFL, fcntl(s, F_GETFL) | O_NONBLOCK);
+			__syscall(SYS_fcntl, s, F_SETFL, O_NONBLOCK);
 	}
 	return s;
 }