the expression -off is not safe in case off is the most-negative value. instead apply - to base which is known to be non-negative and bounded within sanity.
@@ -28,7 +28,7 @@ static off_t ms_seek(FILE *f, off_t off, int whence)
errno = EINVAL;
return -1;
}
- if (-off > base || off > SSIZE_MAX-base) goto fail;
+ if (off < -base || off > SSIZE_MAX-base) goto fail;
return c->pos = base+off;
@@ -29,7 +29,7 @@ static off_t wms_seek(FILE *f, off_t off, int whence)
- if (-off > base || off > SSIZE_MAX/4-base) goto fail;
+ if (off < -base || off > SSIZE_MAX/4-base) goto fail;
memset(&c->mbs, 0, sizeof c->mbs);