Преглед на файлове

fix off-by-one bug in siglongjmp that caused unpredictable behavior

if saved, signal mask would not be restored unless some low signals
were masked. if not saved, signal mask could be wrongly restored to
uninitialized values. in any, wrong mask would be restored.

i believe this function was written for a very old version of the
jmp_buf structure which did not contain a final 0 field for
compatibility with siglongjmp, and never updated...
Rich Felker преди 13 години
родител
ревизия
338b663ddb
променени са 1 файла, в които са добавени 1 реда и са изтрити 1 реда
  1. 1 1
      src/signal/siglongjmp.c

+ 1 - 1
src/signal/siglongjmp.c

@@ -4,7 +4,7 @@
 
 void siglongjmp(sigjmp_buf buf, int ret)
 {
-	unsigned long *flag = buf + sizeof(jmp_buf)/sizeof(long);
+	unsigned long *flag = buf + sizeof(jmp_buf)/sizeof(long) - 1;
 	sigset_t *mask = (void *)(flag + 1);
 	if (*flag)
 		sigprocmask (SIG_SETMASK, mask, NULL);