Browse Source

fix return value of pthread_getaffinity_np and pthread_setaffinity_np

these functions are expected to return an error code rather than
setting errno and returning -1.
Rich Felker 10 years ago
parent
commit
66140b0c92
1 changed files with 11 additions and 8 deletions
  1. 11 8
      src/sched/affinity.c

+ 11 - 8
src/sched/affinity.c

@@ -11,20 +11,23 @@ int sched_setaffinity(pid_t tid, size_t size, const cpu_set_t *set)
 
 int pthread_setaffinity_np(pthread_t td, size_t size, const cpu_set_t *set)
 {
-	return syscall(SYS_sched_setaffinity, td->tid, size, set);
+	return -__syscall(SYS_sched_setaffinity, td->tid, size, set);
 }
 
-int sched_getaffinity(pid_t tid, size_t size, cpu_set_t *set)
+static int do_getaffinity(pid_t tid, size_t size, cpu_set_t *set)
 {
 	long ret = __syscall(SYS_sched_getaffinity, tid, size, set);
-	if (ret > 0) {
-		if (ret < size) memset((char *)set+ret, 0, size-ret);
-		ret = 0;
-	}
-	return __syscall_ret(ret);
+	if (ret < 0) return ret;
+	if (ret < size) memset((char *)set+ret, 0, size-ret);
+	return 0;
+}
+
+int sched_getaffinity(pid_t tid, size_t size, cpu_set_t *set)
+{
+	return __syscall_ret(do_getaffinity(tid, size, set));
 }
 
 int pthread_getaffinity_np(pthread_t td, size_t size, cpu_set_t *set)
 {
-	return sched_getaffinity(td->tid, size, set);
+	return -do_getaffinity(td->tid, size, set);
 }