Prechádzať zdrojové kódy

fix uninitialized output from sched_getaffinity

the sched_getaffinity syscall only fills a cpu set up to the set size
used/supported by the kernel. the rest is left untouched and userspace
is responsible for zero-filling it based on the return value of the
syscall.
Rich Felker 10 rokov pred
rodič
commit
a56e339419
1 zmenil súbory, kde vykonal 5 pridanie a 1 odobranie
  1. 5 1
      src/sched/affinity.c

+ 5 - 1
src/sched/affinity.c

@@ -1,5 +1,6 @@
 #define _GNU_SOURCE
 #include <sched.h>
+#include <string.h>
 #include "pthread_impl.h"
 #include "syscall.h"
 
@@ -16,7 +17,10 @@ int pthread_setaffinity_np(pthread_t td, size_t size, const cpu_set_t *set)
 int sched_getaffinity(pid_t tid, size_t size, cpu_set_t *set)
 {
 	long ret = __syscall(SYS_sched_getaffinity, tid, size, set);
-	if (ret > 0) ret = 0;
+	if (ret > 0) {
+		if (ret < size) memset((char *)set+ret, 0, size-ret);
+		ret = 0;
+	}
 	return __syscall_ret(ret);
 }