fix undefined call order in fclose, possible lost output depending on compiler · bd67467325 - Gogs

fix undefined call order in fclose, possible lost output depending on compiler

pcc turned up this bug by calling f->close(f) before fflush(f),
resulting in lost output and error on flush.

Rich Felker 14 years ago

parent

a9be201cc0

commit

bd67467325

1 changed files with 1 additions and 1 deletions

Split View Show Diff Stats

						
							+ 1
							
							- 1
						
src/stdio/fclose.c
							 
								View File
							
				@@ -13,7 +13,7 @@ int fclose(FILE *f)
			
				 		OFLUNLOCK();
			
				 	}
			
				-	r = fflush(f) | f->close(f);
			
				+	r = -(fflush(f) || f->close(f));
			
				 	if (!perm) free(f);