浏览代码

use atomic decrement rather than cas in pthread_exit thread count

now that blocking signals prevents any application code from running
while the last thread is exiting, the cas logic is no longer needed to
prevent decrementing below zero.
Rich Felker 12 年之前
父节点
当前提交
c3a6839ce9
共有 1 个文件被更改,包括 1 次插入4 次删除
  1. 1 4
      src/thread/pthread_create.c

+ 1 - 4
src/thread/pthread_create.c

@@ -12,7 +12,6 @@ weak_alias(dummy_0, __pthread_tsd_run_dtors);
 _Noreturn void pthread_exit(void *result)
 _Noreturn void pthread_exit(void *result)
 {
 {
 	pthread_t self = pthread_self();
 	pthread_t self = pthread_self();
-	int n;
 
 
 	self->result = result;
 	self->result = result;
 
 
@@ -38,9 +37,7 @@ _Noreturn void pthread_exit(void *result)
 	 * reasons as well. */
 	 * reasons as well. */
 	__syscall(SYS_rt_sigprocmask, SIG_BLOCK, SIGALL_SET, 0, _NSIG/8);
 	__syscall(SYS_rt_sigprocmask, SIG_BLOCK, SIGALL_SET, 0, _NSIG/8);
 
 
-	do n = libc.threads_minus_1;
-	while (n && a_cas(&libc.threads_minus_1, n, n-1)!=n);
-	if (!n) exit(0);
+	if (a_fetch_add(&libc.threads_minus_1, -1)==0) exit(0);
 
 
 	if (self->detached && self->map_base) {
 	if (self->detached && self->map_base) {
 		/* Detached threads must avoid the kernel clear_child_tid
 		/* Detached threads must avoid the kernel clear_child_tid