Jelajahi Sumber

remove always-true conditional in dynamic linker TLSDESC processing

the allocating path which can fail is for dynamic TLS, which can only
occur at runtime, and the check for runtime was already made in the
outer conditional.
Rich Felker 10 tahun lalu
induk
melakukan
c5ab5bd3be
1 mengubah file dengan 1 tambahan dan 1 penghapusan
  1. 1 1
      src/ldso/dynlink.c

+ 1 - 1
src/ldso/dynlink.c

@@ -340,7 +340,7 @@ static void do_relocs(struct dso *dso, size_t *rel, size_t rel_size, size_t stri
 					error(
 					"Error relocating %s: cannot allocate TLSDESC for %s",
 					dso->name, sym ? name : "(local)" );
-					if (runtime) longjmp(*rtld_fail, 1);
+					longjmp(*rtld_fail, 1);
 				}
 				new->next = dso->td_index;
 				dso->td_index = new;