Browse Source

make dladdr consistently produce the first symbol in presence of aliases

the early-exit condition for the symbol match loop on exact matches
caused dladdr to produce the first match for an exact match, but the
last match for an inexact match. in the interest of consistency,
require a strictly-closer match to replace an already-found one.
Rich Felker 6 năm trước cách đây
mục cha
commit
f6870d6b4f
1 tập tin đã thay đổi với 1 bổ sung1 xóa
  1. 1 1
      ldso/dynlink.c

+ 1 - 1
ldso/dynlink.c

@@ -1978,7 +1978,7 @@ int dladdr(const void *addr_arg, Dl_info *info)
 		 && (1<<(sym->st_info&0xf) & OK_TYPES)
 		 && (1<<(sym->st_info>>4) & OK_BINDS)) {
 			size_t symaddr = (size_t)laddr(p, sym->st_value);
-			if (symaddr > addr || symaddr < best)
+			if (symaddr > addr || symaddr <= best)
 				continue;
 			best = symaddr;
 			bestsym = sym;